Open
Conversation
Unity 5 expects string values that contain "-" characters to be quote escaped like Xcode does
Previously file references that already existed but had a build phase set would be ignored. Unity 5 generates file references e.g AdSupport.framework that don't belong to any build phase. Change the way file references are added so that a change to a build phase will add that file to the required build phase. Required changing the build references to not allow duplicates
Was throwing an exception because it already exists
applied correctly. Also move compiler flags from file references to build files since thats where they are saved
Still support Unity 4.x though
Don’t need it printing out for other platforms
Owner
|
Hi, @quasmon Sorry for the late reply. Thanks for the p-r, it looks great to me. Unity 5 has its own dependency system to add frameworks and third party files easier than Unity 4. So the priority to support Unity 5 is not so high currently. But I will take a look at it and try to resolve the conflict and merge it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I ran into a few issues while getting our projects working with Unity 5 and wanted to share the fixes as some people might find them helpful:
Feel free to let me know if you need anything changed.
Cheers,
Ramon.