Draft
Conversation
gouttegd
reviewed
Dec 22, 2025
| ArrayMetadata m = array.metadata(); | ||
| if (array instanceof dev.zarr.zarrjava.v3.Array) { | ||
| // TODO: Implement!! | ||
| res.put("littleEndian", true); |
There was a problem hiding this comment.
I may be completely wrong here, but my understanding is that, with v3, we do not actually have to care about the endianness of the data as stored, because this is already dealt with by the bytes codec.
Regardless of the original endianness, the bytes codec as implemented by Zarr-Java should ensure that at the end, what we get is always using the “native” byte order, which for Java is always big endian.
If I am correct, all we need to do here is always report the endianness as “big-endian” (res.put("littleEndian", false)), because that’s what we effectively see (even if the actual data were stored in little endian order).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Caveats:
Todo: