minor improvements to the Makefile target "dkms-install"#35
Open
feiyax wants to merge 2 commits intoocerman:masterfrom
Open
minor improvements to the Makefile target "dkms-install"#35feiyax wants to merge 2 commits intoocerman:masterfrom
feiyax wants to merge 2 commits intoocerman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just attempted to install it after a fresh minimal install of ubuntu 20.04, then of course it failed due to no
dkms.After installing
dkmsvia package manager, it failed again due tomkdir'ing an existing path, which was the residue from the last unsuccessful attempt.Suggesting to make changes so that:
-parg tomkdirso that it doesn't fail if the path exists alreadydkmsavailability before any action in thedkms-installtarget, so that it will neither create directory nor copy those paths ifdkmsis unavailable.