Open
Conversation
--compiler-version continues to require an explicitly recognised version, but allow the build to proceed with unknown compiler versions. In particular, the list then doesn't need updating on any point release of existing compiler, and stdcompat can be pinned with a development of OCaml up to the point where a new function is added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dune changes in #54 require a new release of stdcompat for any point releases of OCaml (for example 5.3.1). While 4.07.1 required a minor update, this is very much the exception rather than the rule, and it seems better that the version detection be more liberal. There's also a window on trunk OCaml before anything new is added where the package is still usable.
This change proposes being as liberal as
configure.ac---compiler-versionstill requires a recognised OCaml version, though.