Completion update #788
Completion update #788
Conversation
This replaces consult-preview-at-point-mode
Introduce embark--with-completion-list-buffer which switches to an active completions buffer if there is one tied to the current minibuffer.
The completion list candidate takes precendence if there is one. Only if no candidate has been selected, take the top minibuffer candidate.
|
For testing I recommend the settings from https://github.com/minad/consult?tab=readme-ov-file#default-completion-ui-with-auto-update. These settings make the default completion UI more comfortable to use. |
|
Oh, is this something I need to test on the current master? I'm using the released Emacs 30.1. Since I have now lost most of my fear of compiling Emacs from source I guess I could test this. |
|
Yes, you need Emacs master. I had forgotten that you've just moved to Emacs 30 a while ago. :/ But if you can test on Emacs 30 it would also be good, I guess. My main concern is the reordering of the target finder. I am not sure if this has unexpected implications. |
minad
force-pushed
the
completion-update
branch
from
708c4bf to
f21dedb
Compare
|
@oantolin Did you find time to look at this? As mentioned, the main question is if you think that the reordering of the target finder is correct. I have tested this for a while and I am confident that it is okay. |
Consult and other packages also require Emacs 29.1. Emacs 29.1 is widely available, e.g., on Debian stable.
|
I added a bunch of additional maintenance commits. |
minad
force-pushed
the
completion-update
branch
from
795a369 to
8729593
Compare
|
Hi, @minad. I'm very sorry I haven't had a chance to test this yet. But I haven't forgotten about it and hope to get to this next week. |
|
Thanks. No worries. It is not urgent. |
2 participants
Fixes #787. Please test carefully. You need
minibuffer-visible-completionsset totin order to see the effect. This settings allows you to "remote" control the Completions buffer from the minibuffer. You can navigate with up and down keys from the minibuffer.