chore!: update dotnet 10 #84

Marc-Antoine-Soucy · 2026-01-08T19:40:00Z

GitHub Issue: #

Proposed Changes

Description

Updated app to .NET 10, and dropped support for xamarin android, xamarin iOS, and UWP targets.

Impact on version

Major (Public API was modified.)
- Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
- Public members were removed or renamed.
- Public method signatures were changed or renamed.
Minor (Public API was extended.)
- Public constructs, members, or overloads were added.
Patch (Public API was unchanged.)
- A bug in behavior was fixed.
- Documentation was changed.
None (The library is unchanged.)
- Only code under the build folder was changed.
- Only code under the .github folder was changed.

PR Checklist

Your conventional commits are aligned with the Impact on version section.
Documentation is up to date.
- Content of README.md is up to date.
- XML documentation is up to date.
The BREAKING_CHANGES.md document is up to date.
- Create a new Major.0.0 header if you do a Major change and list the breaking changes.
Tested on all relevant platforms

Other information

Internal Issue (If applicable):

lesterbotello · 2026-01-19T18:47:00Z

BiometryService.sln

Should we take the opportunity to get rid of the SLN file and convert it to the new SLNX format?

https://devblogs.microsoft.com/dotnet/introducing-slnx-support-dotnet-cli/#getting-started

Copilot

Pull request overview

This pull request upgrades the BiometryService library from .NET 7 to .NET 10 and removes support for legacy platforms (Xamarin Android, Xamarin iOS, and UWP). This is a breaking change that modernizes the codebase and aligns with current .NET ecosystem standards.

Changes:

Updated target frameworks from net7.0 to net10.0 across all projects
Removed support for Xamarin Android, Xamarin iOS, and UWP platforms
Updated package dependencies to versions compatible with .NET 10
Removed legacy Xamarin sample projects (iOS, Android, UWP)
Updated C# language version from 11.0 to 14.0

Reviewed changes

Copilot reviewed 34 out of 53 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/BiometryService/BiometryService.csproj	Updated to .NET 10 with modern SDK and removed legacy Xamarin/UWP targets
src/BiometryService/BiometryService.UWP.cs	Deleted - UWP implementation removed
src/BiometryService.Abstractions/BiometryService.Abstractions.csproj	Updated language version and package references
samples/BiometryService.SampleApp.Uno.Mobile/BiometryService.SampleApp.Uno.Mobile.csproj	Updated to .NET 10 with modern Uno platform packages
samples/BiometryService.SampleApp.Uno.WinUI/BiometryService.SampleApp.Uno.WinUI.csproj	Updated target framework to .NET 10 Windows
samples/BiometryService.SampleApp.Uno.Shared/App.xaml.cs	Simplified application initialization by removing legacy code
samples/BiometryService.SampleApp.Uno.Shared/MainPage.xaml.cs	Removed logger factory parameters from BiometryService constructors
samples/BiometryService.SampleApp.Uno.iOS/*	Deleted - legacy Xamarin iOS project removed
samples/BiometryService.SampleApp.Uno.Droid/*	Deleted - legacy Xamarin Android project removed
samples/BiometryService.SampleApp.Uno.UWP/*	Deleted - UWP project removed
BiometryService.sln	Removed references to deleted legacy projects
build/azure-pipelines.yml	Updated to Windows 2025 agent image
Directory.Build.targets	Deleted - SourceLink workaround no longer needed
BREAKING_CHANGES.md	Documented breaking changes for version 3.0.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-19T18:47:17Z

BREAKING_CHANGES.md

+
+* Added support for .NET 10.
+* Dropped support for .NET 7.
+* Dropped supporort for Xamarin Android, Xamarin iOS and UWP.


There is a spelling error in this line. "supporort" should be "support".

Suggested change

* Dropped supporort for Xamarin Android, Xamarin iOS and UWP.

* Dropped support for Xamarin Android, Xamarin iOS and UWP.

Copilot · 2026-01-19T18:47:18Z

src/BiometryService/BiometryService.csproj

 		<GenerateDocumentationFile>true</GenerateDocumentationFile>
-		<PackageTags>biometry;FaceID;TouchID;Fingerprint;mvvm;maui;winui;ios;android;xamarin;uwp</PackageTags>
+		<GenerateLibraryLayout>true</GenerateLibraryLayout>
+		<PackageTags>biometry;FaceID;TouchID;Fingerprint;mvvm;maui;winui;ios;android;xamarin</PackageTags>


The PackageTags still includes "xamarin" even though Xamarin Android and Xamarin iOS support has been dropped. Consider removing this tag to avoid confusion, or clarify that it only refers to the Xamarin.AndroidX packages still being used.

Copilot · 2026-01-19T18:47:18Z

BiometryService.sln

-# Visual Studio Version 17
-VisualStudioVersion = 17.0.31912.275
+# Visual Studio Version 18
+VisualStudioVersion = 18.0.11222.15 d18.0


The VisualStudioVersion contains an unusual format "18.0.11222.15 d18.0" which appears to have extra text ("d18.0") that may not be valid. This should likely be just a version number like "18.0.11222.15".

Suggested change

VisualStudioVersion = 18.0.11222.15 d18.0

VisualStudioVersion = 18.0.11222.15

Copilot · 2026-01-19T18:47:18Z

samples/BiometryService.SampleApp.Uno.Shared/App.xaml.cs


+		public Window CurrentWindow { get; private set; }
+
 		public static App Instance { get; private set; }


The Instance property is declared but never initialized. Either remove this unused property or initialize it in the constructor (e.g., Instance = this;).

Copilot · 2026-01-19T18:47:18Z

src/BiometryService/BiometryService.csproj

+	<ItemGroup Condition="'$(TargetFramework)' == 'net10.0-android'">
+	  <PackageReference Include="Xamarin.Google.Android.Material">
+	    <Version>1.12.0.4</Version>
+	  </PackageReference>
+	</ItemGroup>


This ItemGroup duplicates the Android package references already defined in lines 49-54. The Xamarin.Google.Android.Material package should be added to the existing Android ItemGroup above rather than creating a separate one. This creates redundancy and inconsistency in the project structure.

Copilot · 2026-01-19T18:47:19Z

samples/BiometryService.SampleApp.Uno.Shared/MainPage.xaml.cs

+			promptBuilder
 		);
 #endif
 #if WINDOWS_UWP || WINDOWS


The WINDOWS_UWP conditional compilation directive is still included even though UWP support has been dropped. This should be changed to just WINDOWS to avoid confusion, as WINDOWS_UWP is no longer a supported platform.

Suggested change

#if WINDOWS_UWP || WINDOWS

#if WINDOWS

chore!: update dotnet 10

86235ae

Soap-141 requested review from Soap-141, Copilot, jeanplevesque and lesterbotello and removed request for Soap-141 January 19, 2026 18:42

Soap-141 assigned Marc-Antoine-Soucy Jan 19, 2026

Copilot started reviewing on behalf of Soap-141 January 19, 2026 18:43 View session

lesterbotello reviewed Jan 19, 2026

View reviewed changes

Copilot AI reviewed Jan 19, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore!: update dotnet 10 #84

chore!: update dotnet 10 #84

Uh oh!

Marc-Antoine-Soucy commented Jan 8, 2026

Uh oh!

lesterbotello Jan 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Copilot AI Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	* Dropped supporort for Xamarin Android, Xamarin iOS and UWP.
	* Dropped support for Xamarin Android, Xamarin iOS and UWP.

	VisualStudioVersion = 18.0.11222.15 d18.0
	VisualStudioVersion = 18.0.11222.15


		public Window CurrentWindow { get; private set; }

		public static App Instance { get; private set; }

chore!: update dotnet 10 #84

Are you sure you want to change the base?

chore!: update dotnet 10 #84

Uh oh!

Conversation

Marc-Antoine-Soucy commented Jan 8, 2026

Proposed Changes

Description

Impact on version

PR Checklist

Other information

Internal Issue (If applicable):

Uh oh!

lesterbotello Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants