Skip to content

Conversation

@Lee31416
Copy link

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Updating the contributing documentation

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

PR Checklist

  • Your conventional commits are aligned with the Impact on version section.
  • Documentation is up to date.
    • Content of README.md is up to date.
    • XML documentation is up to date.
  • The BREAKING_CHANGES.md document is up to date.
    • Create a new Major.0.0 header if you do a Major change and list the breaking changes.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

Add a quick description of your changes.

Impact on version:
Please check the impact of your changes on the version. This should align with the changes made to the changelog file.
Copy link

@Marc-Antoine-Soucy Marc-Antoine-Soucy Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any changes in the changelog file, does this project have one? Should breaking_changes.md be the one we should check instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well some packages have no changelogs and breaking change i thought about it but since it's not a breaking change I thought it wouldnt make much sense

@Lee31416 Lee31416 closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants