Skip to content

Policy probe util#3790

Open
End-rey wants to merge 2 commits intomasterfrom
policy-probe-util
Open

Policy probe util#3790
End-rey wants to merge 2 commits intomasterfrom
policy-probe-util

Conversation

@End-rey
Copy link
Contributor

@End-rey End-rey commented Jan 28, 2026

Closes #3626.

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.53%. Comparing base (827cad9) to head (62de59b).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-cli/modules/container/policy/check.go 0.00% 42 Missing ⚠️
cmd/neofs-cli/modules/container/policy/util.go 0.00% 19 Missing ⚠️
cmd/internal/cmdprinter/netmap.go 0.00% 15 Missing ⚠️
cmd/neofs-cli/modules/container/policy/root.go 0.00% 7 Missing ⚠️
cmd/neofs-cli/modules/container/create.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/container/nodes.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/container/root.go 0.00% 1 Missing ⚠️
cmd/neofs-cli/modules/object/nodes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3790   +/-   ##
=======================================
  Coverage   25.52%   25.53%           
=======================================
  Files         660      664    +4     
  Lines       42636    42688   +52     
=======================================
+ Hits        10884    10899   +15     
- Misses      30749    30788   +39     
+ Partials     1003     1001    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@End-rey End-rey force-pushed the policy-probe-util branch 2 times, most recently from 2b79a01 to b430c89 Compare February 4, 2026 18:53
@End-rey End-rey requested a review from roman-khimov February 4, 2026 18:53
Long: `Check placement policy parsing and validation.
Policy can be provided as QL-encoded string, JSON-encoded string or path to file with it.
Shows nodes that will be used for container placement based on current network map snapshot.`,
Args: cobra.NoArgs,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

policy can naturally be an arg (not a flag) imo, but do not insist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of using flags. I made the flag required for clarity.

@End-rey End-rey force-pushed the policy-probe-util branch 3 times, most recently from 3f75cfd to 62de59b Compare February 9, 2026 13:22
@End-rey End-rey requested a review from carpawell February 9, 2026 13:22
Add a CLI utility to validate container policies and display nodes that are
policy-compliant in the current epoch.

Closes #3626.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide storage policy probe util

4 participants