🚀 Fix CI Testing Issues & Add Performance Monitoring Foundation#20
🚀 Fix CI Testing Issues & Add Performance Monitoring Foundation#20
Conversation
Co-authored-by: nsmaassel <1653803+nsmaassel@users.noreply.github.com>
Co-authored-by: nsmaassel <1653803+nsmaassel@users.noreply.github.com>
|
We ahve an error after running the workflow. Please be sure to use non-deprecated functions. Current runner version: '2.325.0' |
Co-authored-by: nsmaassel <1653803+nsmaassel@users.noreply.github.com>
Fixed the deprecated |
|
Another error in the workflow. The job failed for two main reasons: Duplicate Assembly Attributes Errors like CS0579: Duplicate 'System.Reflection.AssemblyCompanyAttribute' attribute indicate that assembly attributes are being defined more than once, likely in both the .csproj file and in code (such as AssemblyInfo.cs). Check your mcp-sdk-dotnet/McpSdkServer.csproj and McpSdkServer.AssemblyInfo.cs. Remove redundant attribute definitions so each attribute (e.g., AssemblyCompany, AssemblyVersion, etc.) is only set in one place. If you have this in your .csproj: Errors like CS0246: The type or namespace name 'Xunit' could not be found mean that the xUnit test framework is not referenced in your test project. Add xUnit as a project dependency. In mcp-sdk-dotnet/McpSdkServer.Tests/McpSdkServer.Tests.csproj, add: |
|
The job failed due to two main reasons: Duplicate Assembly Attributes Code Solution: Check the file McpSdkServer.csproj and the file McpSdkServer.AssemblyInfo.cs. Code Solution: Add Xunit as a dependency in your test project (McpSdkServer.Tests). Remove duplicate assembly attributes. |
Co-authored-by: nsmaassel <1653803+nsmaassel@users.noreply.github.com>
Fixed both issues in commit 70c0c1a: Duplicate Assembly Attributes: Resolved by relocating the test project from Missing XUnit Reference: Updated to latest stable versions (xUnit 2.6.0, xunit.runner.visualstudio 2.8.0) and added proper project reference to the main McpSdkServer project. All projects now build and test successfully:
|
Co-authored-by: nsmaassel <1653803+nsmaassel@users.noreply.github.com>
Fixed both issues in commit 2e63041: XUnit Package References: Updated to use XUnit 2.5.0 and xunit.runner.visualstudio 2.5.0 as requested for compatibility. Verification:
The CI workflow should now run without the build errors mentioned. |
✅ Review Complete - All CI improvements are working correctly: Status Summary:
Fixed Issues:
The CI workflow is reliable, comprehensive, and ready for production. All Phase 1 objectives completed successfully. |
This PR addresses all Phase 1 (HIGH PRIORITY) issues identified in the comprehensive CI improvement plan, fixing immediate reliability problems and establishing a foundation for future performance monitoring.
🔧 Issues Fixed
❌ Missing Test Project in CI
The
mcp-sdk-dotnet/McpSdkServer.Testsproject had a corrupted.csprojfile and was completely missing from CI.Before:
After:
❌ No Package Restore Step
The CI workflow was missing
dotnet restore, causing intermittent build failures.Before:
After:
❌ Hard-Coded Paths & Limited Test Coverage
Only 2 of 3 test projects were covered due to hard-coded paths.
Before:
After:
❌ No Build Verification
Tests ran without ensuring projects built successfully first.
After:
🚀 CI Workflow Improvements
Dynamic Test Discovery
*Tests.csprojfilesProper Build Chain
--no-restoreand--no-buildfor efficiencySmart Error Handling
Enhanced Logging & Artifacts
${PROJECT_NAME}-test-results.trx📊 Test Results Summary
🎯 Performance Testing Foundation
Added basic performance test framework to establish metrics collection foundation:
This provides the groundwork for future Phase 3 performance benchmarking and Phase 4 Grafana dashboard integration.
🧪 Testing Methodology
The CI improvements were thoroughly tested:
📋 Future Phases
This PR completes Phase 1 and establishes the foundation for:
The CI workflow is now reliable, comprehensive, and ready for the advanced monitoring features planned in subsequent phases.
Fixes #19.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.