Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/novaforgood/risc/6RP1FXD36qZoRxEcvtJ5oxS9MaZm [Deployment for e83a798 failed] |
Added localhost storage of step to preserve progress Removed flash from redirection of onboarding
innopoop
force-pushed
the
Ashley/onboarding
branch
from
9e564c9 to
0c4e302
Compare
alyssamw
left a comment
alyssamw
left a comment
There was a problem hiding this comment.
Happy to approve after compile error is fixed and can see preview.
| authorizationLevel !== AuthorizationLevel.Admin && | ||
| router.asPath !== props.onboardingText[currentStep]["route"] && | ||
| onboardingStep && | ||
| typeof onboardingStep == "number" |
There was a problem hiding this comment.
What does this if condition mean?
There was a problem hiding this comment.
So there are a couple of different routes that require different onboarding but if a user navigates outside of the onboarding page (manually), then we have a way to counteract it because we check to see whether the user is still going through onboarding and if they are, we navigate them back to the designated onboarding step. The if statement, I don't know why I put authorizationLevel !== AuthorizationLevel.Admin I think that was a mistake, but the other conditions check for if the current path matches the step that you are supposed to be on and then it checks if the localstorage variable exists and is a number.
There was a problem hiding this comment.
I've corrected it :' )
| }; | ||
| }; | ||
|
|
||
| export const OnboardingProvider = ({ |
There was a problem hiding this comment.
Curious as to why this is its own provider, am noob to it
There was a problem hiding this comment.
I made it a provider because I wanted to share state among multiple pages, but I think it's also possible to make it a hook?
There was a problem hiding this comment.
Changed it to a hook :' )
innopoop
force-pushed
the
Ashley/onboarding
branch
from
298b023 to
e83a798
Compare
2 participants
Requires respective backend change here