Merged
Conversation
Fix mixed keyword and plain signatures in target_link_libraries calls that were causing CMake build errors on macOS. All calls now use the consistent PRIVATE keyword signature. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add macOS runner to build matrix in build-and-test workflow - Install macOS dependencies via Homebrew (cmake, lua, hidapi) - Add macOS artifact upload to CI workflow - Add macOS build artifacts to release workflow - Include macOS plugin zip in release process 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Create build-macos.sh script to simplify macOS builds: - Checks for macOS environment - Installs dependencies via Homebrew - Configures CMake with local install prefix - Builds and installs plugin to project directory - Provides clear success message with install path 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add Homebrew installation prerequisites - Include PATH setup instructions for Homebrew - Document both script-based and manual build options - Provide clear step-by-step macOS build process - Update dependency installation commands 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update all upload-artifact actions to use the latest v4 version to avoid deprecation warnings and ensure compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add missing #include <chrono> to fix Windows compilation error: 'system_clock': the symbol to the left of a '::' must be a type The code uses std::chrono::system_clock but was missing the required chrono header include. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Let me know if you need testing or any interactive help on macOS :) |
Owner
Author
|
thanks @MrAnno :-) The main purpose of this PR was to test the AI tools. Most of the modifications in this PR were generated by Claude. It's crazy that after parsing my repo, it was able to create a working update on the build system. It's fantastic and scary at the same time. Now I have a MacBook, so there is no excuse to do my tests locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created to support the macOS fully build. During the development I used the AI tool from Claude.ai