Skip to content

test: check stability block position in API markdown#58590

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Renegade334:test-stability-block-position
Feb 14, 2026
Merged

test: check stability block position in API markdown#58590
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Renegade334:test-stability-block-position

Conversation

@Renegade334
Copy link
Member

The doc generator will only add a stability marker to the index if the blockquote element appears close to the relevant heading. There is an ordering convention (<heading> [<yaml>] <stability>) which is not currently enforced.

Adding a test for this identifies one element which is currently non-compliant, buf.slice() in buffer.md, which does not appear as deprecated in the index due to the malpositioned deprecation block.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 5, 2025
@Renegade334 Renegade334 force-pushed the test-stability-block-position branch 2 times, most recently from 7bdc418 to c41bd3e Compare June 5, 2025 19:14
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.72%. Comparing base (65df9ad) to head (f523724).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58590      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.01%     
==========================================
  Files         675      675              
  Lines      204797   204797              
  Branches    39342    39348       +6     
==========================================
- Hits       183767   183764       -3     
- Misses      13294    13299       +5     
+ Partials     7736     7734       -2     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 force-pushed the test-stability-block-position branch from c41bd3e to 91a8078 Compare June 6, 2025 12:43
@Renegade334 Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2025
@nodejs-github-bot

This comment was marked as outdated.

@Renegade334 Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests. labels Feb 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@Renegade334 Renegade334 force-pushed the test-stability-block-position branch from 91a8078 to f523724 Compare February 14, 2026 21:48
@Renegade334
Copy link
Member Author

Rebased as an additional failure case was introduced since the original commit.

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2026
@nodejs-github-bot
Copy link
Collaborator

@Renegade334 Renegade334 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 14, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9cc7fcc into nodejs:main Feb 14, 2026
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9cc7fcc

@Renegade334 Renegade334 deleted the test-stability-block-position branch February 15, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants