Change to using std::min() when allocating Buffers#73
Open
doggkruse wants to merge 2 commits intonode-ffi-napi:latestfrom
Open
Change to using std::min() when allocating Buffers#73doggkruse wants to merge 2 commits intonode-ffi-napi:latestfrom
doggkruse wants to merge 2 commits intonode-ffi-napi:latestfrom
Conversation
…his will result in Buffers being allocated to the size requested up to kMaxLength (0x3fffffff) instead of the current behavior of always allocating kMaxLength. Since these buffers are allocated in the node external memory (limited to 64M) the old behavior would very quickly cause massive GC pressure as the GC is triggered on each new Buffer allocation once the node external memory limit is reached. It appears the old behavior was not intentional and should have always been std::min(). This should fix node-ffi-napi#72
…an the current request. This is likely what drove the problematic max size allocation
|
@addaleax by chance is it possible this to be reviewed and/or merged? It's solving our performance issues in Node.Js 18. However, as @blattersturm mentioned in #72, in Node 14 and 16 does not work because it's throwing |
genaris
added a commit
to 2060-io/ref-napi
that referenced
this pull request
Feb 6, 2023
NOTE: ref-napi now requires node >= 18, as this is not working in previous versions Signed-off-by: Ariel Gentile <gentilester@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will result in Buffers being allocated to the size requested up to kMaxLength (0x3fffffff) instead of the current behavior of always allocating kMaxLength. Since these buffers are allocated in the node external memory (limited to 64M) the old behavior would very quickly cause massive GC pressure as the GC is triggered on each new Buffer allocation once the node external memory limit is reached. It appears the old behavior was not intentional and should have always been std::min(). This should fix #72