Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/njs_disassembler.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,21 @@ njs_disassemble(u_char *start, u_char *end, njs_int_t count, njs_arr_t *lines)
continue;
}

if (operation == NJS_VMCODE_OPTIONAL_CHAIN) {
test_jump = (njs_vmcode_test_jump_t *) p;

njs_printf("%5uD | %05uz OPTIONAL CHAIN "
"%04Xz %04Xz %z\n",
line, p - start,
(size_t) test_jump->retval,
(size_t) test_jump->value,
(size_t) test_jump->offset);

p += sizeof(njs_vmcode_test_jump_t);

continue;
}

if (operation == NJS_VMCODE_FUNCTION_FRAME) {
function = (njs_vmcode_function_frame_t *) p;

Expand Down
136 changes: 136 additions & 0 deletions src/njs_generator.c
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,12 @@ static njs_int_t njs_generate_test_jump_expression_after(njs_vm_t *vm,
njs_generator_t *generator, njs_parser_node_t *node);
static njs_int_t njs_generate_test_jump_expression_end(njs_vm_t *vm,
njs_generator_t *generator, njs_parser_node_t *node);
static njs_int_t njs_generate_optional_chain(njs_vm_t *vm,
njs_generator_t *generator, njs_parser_node_t *node);
static njs_int_t njs_generate_optional_chain_after(njs_vm_t *vm,
njs_generator_t *generator, njs_parser_node_t *node);
static njs_int_t njs_generate_optional_chain_end(njs_vm_t *vm,
njs_generator_t *generator, njs_parser_node_t *node);
static njs_int_t njs_generate_3addr_operation(njs_vm_t *vm,
njs_generator_t *generator, njs_parser_node_t *node, njs_bool_t swap);
static njs_int_t njs_generate_3addr_operation_name(njs_vm_t *vm,
Expand Down Expand Up @@ -661,6 +667,12 @@ njs_generate(njs_vm_t *vm, njs_generator_t *generator, njs_parser_node_t *node)
case NJS_TOKEN_COALESCE:
return njs_generate_test_jump_expression(vm, generator, node);

case NJS_TOKEN_OPTIONAL_CHAIN:
return njs_generate_optional_chain(vm, generator, node);

case NJS_TOKEN_OPTIONAL_CHAIN_REF:
return njs_generator_stack_pop(vm, generator, NULL);

case NJS_TOKEN_DELETE:
case NJS_TOKEN_VOID:
case NJS_TOKEN_UNARY_PLUS:
Expand Down Expand Up @@ -3836,6 +3848,130 @@ njs_generate_test_jump_expression_end(njs_vm_t *vm, njs_generator_t *generator,
}


static njs_parser_node_t *
njs_generate_optional_chain_ref(njs_parser_node_t *node)
{
while (node != NULL) {
if (node->token_type == NJS_TOKEN_OPTIONAL_CHAIN_REF) {
return node;
}

node = node->left;
}

return NULL;
}


static njs_int_t
njs_generate_optional_chain(njs_vm_t *vm, njs_generator_t *generator,
njs_parser_node_t *node)
{
njs_generator_next(generator, njs_generate, node->left);

return njs_generator_after(vm, generator,
njs_queue_first(&generator->stack),
node, njs_generate_optional_chain_after,
NULL, 0);
}


static njs_int_t
njs_generate_optional_chain_after(njs_vm_t *vm, njs_generator_t *generator,
njs_parser_node_t *node)
{
njs_jump_off_t jump_offset;
njs_parser_node_t *ref, *prop, *base_prop, *base, *walk;
njs_vmcode_test_jump_t *test_jump;

njs_generate_code(generator, njs_vmcode_test_jump_t, test_jump,
NJS_VMCODE_OPTIONAL_CHAIN, node);
jump_offset = njs_code_offset(generator, test_jump);
test_jump->value = node->left->index;

node->index = njs_generate_node_temp_index_get(vm, generator, node);
if (njs_slow_path(node->index == NJS_INDEX_ERROR)) {
return node->index;
}

test_jump->retval = node->index;

/*
* Walk left spine to find METHOD_CALL with two OPTIONAL_CHAIN_REF
* children (created for ?.() on a property base like o.m?.()).
*/
walk = node->right;
base_prop = NULL;

while (walk != NULL) {
prop = walk->left;

if (walk->token_type == NJS_TOKEN_METHOD_CALL
&& prop->token_type == NJS_TOKEN_PROPERTY
&& prop->right->token_type == NJS_TOKEN_OPTIONAL_CHAIN_REF)
{
base = node->left;

if (base->token_type == NJS_TOKEN_PROPERTY) {
base_prop = base;

} else if (base->token_type == NJS_TOKEN_OPTIONAL_CHAIN
&& base->right->token_type == NJS_TOKEN_PROPERTY)
{
base_prop = base->right;
}

if (base_prop != NULL) {
prop->left->index = base_prop->left->index;
prop->right->index = base_prop->right->index;
}

break;
}

walk = walk->left;
}

if (base_prop == NULL) {
ref = njs_generate_optional_chain_ref(node->right);
if (ref != NULL) {
ref->index = node->left->index;
}
}

njs_generator_next(generator, njs_generate, node->right);

return njs_generator_after(vm, generator,
njs_queue_first(&generator->stack),
node, njs_generate_optional_chain_end,
&jump_offset, sizeof(njs_jump_off_t));
}


static njs_int_t
njs_generate_optional_chain_end(njs_vm_t *vm, njs_generator_t *generator,
njs_parser_node_t *node)
{
njs_int_t ret;
njs_vmcode_move_t *move;

if (node->index != node->right->index) {
njs_generate_code_move(generator, move, node->index,
node->right->index, node);
}

njs_code_set_jump_offset(generator, njs_vmcode_test_jump_t,
*((njs_jump_off_t *) generator->context));

ret = njs_generate_children_indexes_release(vm, generator, node);
if (njs_slow_path(ret != NJS_OK)) {
return ret;
}

return njs_generator_stack_pop(vm, generator, generator->context);
}


static njs_int_t
njs_generate_3addr_operation(njs_vm_t *vm, njs_generator_t *generator,
njs_parser_node_t *node, njs_bool_t swap)
Expand Down
3 changes: 3 additions & 0 deletions src/njs_lexer.h
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ typedef enum {
NJS_TOKEN_PROPERTY_SETTER,
NJS_TOKEN_PROTO_INIT,

NJS_TOKEN_OPTIONAL_CHAIN,
NJS_TOKEN_OPTIONAL_CHAIN_REF,

NJS_TOKEN_ARRAY,

NJS_TOKEN_GRAVE,
Expand Down
Loading