Add Carthage and latest swift support#19
Open
younata wants to merge 2 commits intonghialv:masterfrom
younata:master
Open
Add Carthage and latest swift support#19younata wants to merge 2 commits intonghialv:masterfrom younata:master
younata wants to merge 2 commits intonghialv:masterfrom
younata:master
Conversation
|
+1 |
Author
|
ping @nghialv This is up to date with latest commits from upstream (you). Would appreciate this getting merged in. |
Owner
|
Hi @younata . Sorry for the late reply. Would you have time to update this PR? |
Author
|
@nghialv Done. Thanks for finding time for this. |
|
👍 even if it has conflicts.. that's to be expected after neglecting it for over half a year.. 😞 |
|
So, any plans on finishing this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would have these as two separate commits, but I needed to upgrade to latest swift in order to test that it works with Carthage.