Parallelise uploads #16268
Open
Parallelise uploads #16268
+573
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad safe vars and make sure UI updates accordingly Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
… safety Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
…progress Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
k0raph
force-pushed
the
parallelise-uploads
branch
from
bd4ef78 to
1a5bac6
Compare
2 tasks
Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
k0raph
commented
Jan 12, 2026
| /** | ||
| * The maximum number of concurrent parallel uploads | ||
| */ | ||
| const val MAX_CONCURRENT_UPLOADS = 10 |
Author
There was a problem hiding this comment.
Should the user be given flexibility over this field?
There was a problem hiding this comment.
It would be helpfull as depending on the phone specs and "bloat" on the phone it may freeze or lag substantially.
Author
There was a problem hiding this comment.
I've added a shared preference - "Max concurrent uploads", that the user can configure.
…ting easier. Added various unit tests and an IT to test the FileUploadWorker Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
…roid into parallelise-uploads
…ting easier. Added various unit tests and an IT to test the FileUploadWorker Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
…current uploads Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
…loads Shared preference - Max concurrent uploads
Signed-off-by: Raphael Vieira <raphaelecv@hotmail.com>
…roid into parallelise-uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10124
This PR aims to introduce improvements to the file upload process by parallelizing uploads using Kotlin Coroutines and a Semaphore (which I defaulted to 10 concurrent tasks) to improve throughput.
Key Changes