Fix: Text burning issue #189
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes, randomly and intermittently, text frames are not only exported in the HTML output, but are also burned into the image outputs, resulting in texts that appear visually duplicated (see #150).
The issue seems to arise from some non-deterministic race condition with certain (often large) AI documents, where the
hiddenproperty is not properly applied before images are exported.Proposed fix
A solution would be to hide text frames by setting their opacity to 0, rather than using the flawed
hiddenproperty. As semi-transparent texts are supported, the original opacity is saved and restored after image outputs have been generated.Potential concerns & caveats
render_text_as: imagesetting is used, so no worries here.