Conversation
- Add missing voxel_res parameter to all generate_stack_and_template calls in STAGE1, STAGE2, and groupwise sections of run_slice_registration.py - Add voxel_res parameter to groupwise_stack_optimization function signature - Fix convert_ants_warp_to_deformation signature to accept reference_image arg (called with 3 args but defined with only 2) - Fix do_initial_translation_reg to pass voxel_res and use_resolution_in_registration through to do_reg - Fix executor.submit() call to properly pass function reference instead of calling function immediately (do_initial_translation_reg) Co-authored-by: steelec <2734273+steelec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix resolution issues in slice registration functions
Fix voxel_res propagation and function signature mismatches in slice registration pipeline
Feb 14, 2026
steelec
reviewed
Feb 14, 2026
Member
steelec
left a comment
There was a problem hiding this comment.
primarily surface level changes, should be good but will not affect current issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution (
voxel_res) was only propagated through the first few pipeline steps. All STAGE1, STAGE2, and groupwise template generation calls silently defaulted to 1×1×1. Additionally,convert_ants_warp_to_deformationwould crash at runtime due to a signature mismatch.slice_registration_functions.pydo_initial_translation_reg: Forwardvoxel_resanduse_resolution_in_registrationthrough todo_reg— both were accepted but silently droppedconvert_ants_warp_to_deformation: Addreference_imageparam to signature — called with 3 args fromgroupwise_stack_optimizationbut defined with 2 (TypeErrorat runtime)groupwise_stack_optimization: Addscaling_factorandvoxel_resto signature to match callerrun_slice_registration.pyvoxel_res=voxel_resto all 10generate_stack_and_templatecalls that were missing it (STAGE1, STAGE2, groupwise)voxel_restogroupwise_stack_optimizationexecutor.submit()for initial translation — wasexecutor.submit(fn(...))(immediate call, serial) instead ofexecutor.submit(fn, ...)(deferred, parallel):Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.