Conversation
Example: ``` Function 'overloadOf' has inline specifier but is implicitly inlined (fix available) [readability-redundant-inline-specifier] ```
``` Rvalue reference parameter 'slot' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved] ```
``` use 'std::scoped_lock' instead of 'std::lock_guard' [modernize-use-scoped-lock] ```
``` included header string is not used directly [misc-include-cleaner] ```
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GoogleTest framework to support C++20, involving significant refactoring and modernization of the codebase. The changes align with newer C++ standards and improve code quality.
Key Changes
- Upgrade preprocessor macros from
#ifto#ifdef/#if defined()for better consistency - Replace deprecated APIs and remove legacy code patterns
- Add new functionality including C++20 features and improved test infrastructure
- Reorganize header includes and improve code formatting
Reviewed Changes
Copilot reviewed 46 out of 48 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/gtest/src/gtest_main.cc | Updated platform detection macros and reorganized main entry points for different platforms |
| tests/gtest/src/gtest.cc | Major refactoring with updated flag handling, improved test filtering logic, and C++20 compatibility |
| tests/gtest/src/gtest-typed-test.cc | Code formatting improvements and simplified conditionals |
| tests/gtest/src/gtest-test-part.cc | Cleaned up streaming operators and simplified code structure |
| tests/gtest/src/gtest-printers.cc | Added 128-bit integer support and updated character handling for C++20 |
| tests/gtest/src/gtest-port.cc | Improved platform-specific code organization and thread handling |
| tests/gtest/src/gtest-matchers.cc | Reordered includes for better dependency management |
| tests/gtest/src/gtest-internal-inl.h | Updated flag accessors from direct access to getter/setter macros |
| tests/gtest/src/gtest-filepath.cc | Enhanced path handling with better Windows UNC support |
| tests/gtest/src/gtest-assertion-result.cc | New file extracting AssertionResult implementation |
| tests/gtest/src/gtest-all.cc | Updated to include new source file |
| tests/gtest/include/gtest/internal/gtest-string.h | Minor formatting and documentation improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.