Replacing deprecated python cookbook with poise-python#13
Replacing deprecated python cookbook with poise-python#13jaymed wants to merge 2 commits intonetflash:masterfrom
Conversation
…lt install package to version 2.5. Moving location of as.conf under the etc/ folder.
| done | ||
| echo 'collecting extra files' | ||
| cp $OPENVPNAS_DIR/etc/as.conf $BACKUP_DIR | ||
| cp $OPENVPNAS_DIR/etc/config.json $BACKUP_DIR |
There was a problem hiding this comment.
What is the reason to remove this line ?
There was a problem hiding this comment.
Looks like that file is generated during the restore process. Latest openvpn backup/restore docs don't make reference to that file. https://docs.openvpn.net/configuration/migrating-an-access-server-installation/
| *.un~ | ||
|
|
||
| # Bundler | ||
| Gemfile.lock |
There was a problem hiding this comment.
not sure it's a good idea to gitignore this file
There was a problem hiding this comment.
I picked up a boiler place .gitignore file from a different cookbook project. I was simply trying to avoid checking in the .kitchen folder/directory and Berksfile.lock since I don't think those files need to be committed. I can remove this file.
There was a problem hiding this comment.
I don't mind ignoring it, but if we go this way we should remove the file from the repo first.
There was a problem hiding this comment.
And I guess if you remove it, it'll fix travis build
There was a problem hiding this comment.
I'll work on getting the build back in working order. I haven't had much time to look into it. Looks like just deleting the .lock file didn't work.
2 participants
No description provided.