Implement search suggestions so the OpenSearch XML we ship works#390
Open
lf- wants to merge 1 commit intondmitchell:masterfrom
Open
Implement search suggestions so the OpenSearch XML we ship works#390lf- wants to merge 1 commit intondmitchell:masterfrom
lf- wants to merge 1 commit intondmitchell:masterfrom
Conversation
Bodigrim
reviewed
Dec 16, 2025
| Just f -> pure $ OutputFail $ lbstrPack $ "Format mode " ++ f ++ " not (currently) supported" | ||
| Nothing -> pure $ OutputJSON $ JSON.toEncoding filteredResults | ||
| Just "suggest" -> let | ||
| filteredResults = take 25 results |
Collaborator
There was a problem hiding this comment.
I'm a bit worried about bot load, could we make it, say, 5 instead of 25?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #389.
That wasn't that bad.
This now works in Firefox and Chrome, which is pretty cool.
I tested this locally by hacking up the XML files Hoogle ships:
html/search.xml:I'm not sure the best way to do this templating to replace the URLs at present, so I'm leaving that to future work to make that work locally.