Open
Conversation
…Address instructions.
Hywan
reviewed
Nov 26, 2018
| /// can be convert to this one, including NumberValue, using the `into()` | ||
| /// method. | ||
| #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Hash, Clone, Copy)] | ||
| pub enum NumberType { |
Contributor
There was a problem hiding this comment.
Is it interesting to support i128 and u128 here?
Owner
Author
There was a problem hiding this comment.
The problem with having NumberType for i128 and u128 is that we need a corresponding NumberValue and at the moment NumberValue are part of the Opcode::Const, Thus increasing the size of all opcodes.
Support for 128 bits number is something which would have to be handled to support Rust fully, but this can be expressed as 64 bits operations.
The Library macro create an empty tuple pointer storage to reference the space which contains the value of all the statics value sused during the compilation. This implies that the library cannot use the untyped tuple type to derive the size, using mem::size_of, to assert its size when registering the memory of statics.
The debug mode is enabling `-Z dump-mir=all` flag which attemps to spew the content of the `&[u8]` array containing the serialized content. This arrau serialization is time consuming and should be removed in the future by replacing it by a `&str`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a work-in-progress to handle the LIR to Cranelift IR conversion. It adds a LIR representation #29 and adds a Cranelift backend #28 .
However it does not yet change the MIR to LIR mapping nor the serialization of the LIR. Thus, this pull request cannot yet be tested with a complete pipeline to handle the Brainfuck example. Tests for this pull requests are added as part of the test of the newly added
codegensub-project. These tests are creating LIR units which are then lowered into Cranelift IR, compiled and tested.