This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Fix action bar color according to the theme selected.#109
Open
tralves wants to merge 1 commit intonativescript-vue:masterfrom
Open
Fix action bar color according to the theme selected.#109tralves wants to merge 1 commit intonativescript-vue:masterfrom
tralves wants to merge 1 commit intonativescript-vue:masterfrom
Conversation
Member
|
This is something I wanted to do, but haven't gotten around to doing yet. Ideally I'd like to make the theme optional, as for most projects I work on, I don't need it, and there is no easy way to opt-out currently. What I'm thinking is adding conditions to only add the |
Contributor
Author
|
I can do that. But then we also need to add a |
Member
Yes, that would be the plan to be able to select "none" and then no extra classes are added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98.
Even if in the future you remove the
nativescript-theme-core(replacing withns-tailwind? ;) ), right now it is pretty confusing. I just lost an embarrassing amount of time because I picked the theme 'forest' and just assumed that the action bar color was coming from the theme...Anyway, this is a small fix that I think improves the current template.