Skip to content

fix: quote username in db queries #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyrremann merged 1 commit into from
Jan 12, 2026
Merged

fix: quote username in db queries #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/postgres/iam.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,18 +271,18 @@ func AddUser(ctx context.Context, appName, username, password string, cluster fl
return err
}

_, err = db.ExecContext(ctx, fmt.Sprintf("CREATE USER %v WITH ENCRYPTED PASSWORD '%v' NOCREATEDB;", username, password))
_, err = db.ExecContext(ctx, fmt.Sprintf("CREATE USER '%v' WITH ENCRYPTED PASSWORD '%v' NOCREATEDB;", username, password))
if err != nil {
return formatInvalidGrantError(err)
}
out.Printf("Created user: %v", username)

_, err = db.ExecContext(ctx, fmt.Sprintf("alter default privileges in schema public grant %v on tables to %q;", privilege, username))
_, err = db.ExecContext(ctx, fmt.Sprintf("alter default privileges in schema public grant %v on tables to '%q';", privilege, username))
if err != nil {
return formatInvalidGrantError(err)
}

_, err = db.ExecContext(ctx, fmt.Sprintf("grant %v on all tables in schema public to %q;", privilege, username))
_, err = db.ExecContext(ctx, fmt.Sprintf("grant %v on all tables in schema public to '%q';", privilege, username))
if err != nil {
return formatInvalidGrantError(err)
}
Expand All @@ -306,7 +306,7 @@ func DropUser(ctx context.Context, appName string, username string, cluster flag
return err
}

_, err = db.ExecContext(ctx, fmt.Sprintf("drop role %v;", username))
_, err = db.ExecContext(ctx, fmt.Sprintf("drop role '%v';", username))
if err != nil {
return formatInvalidGrantError(err)
}
Expand Down