Custom options, passed to event handlers#26
Open
hashchange wants to merge 19 commits intomxriverlynn:masterfrom
Open
Custom options, passed to event handlers#26hashchange wants to merge 19 commits intomxriverlynn:masterfrom
hashchange wants to merge 19 commits intomxriverlynn:masterfrom
Conversation
deselectAll is more consistent with the rest of the API; selectNone is kept around for compatibility.
If a selectable model belongs to more than one selectable collection then only the initial collection will have it's select() method called. Also, if a model is initially added to a non-selectable collection, and then later added to a selectable collection the 2nd collection will not have it's select() method called, and a error will be thrown as the initial collection will not have a select() method.
Backbone 1.0.0, Underscore 1.5.0. Using the listenTo and stopListening methods requires at least Backbone 0.9.9.
The extended model or collection is passed to the mixin as an argument now.
Events still need to be improved, those tests are failing.
Plus trivial changes in the tests to get rid of some warnings when committing.
…e in spec) Previously, selectAll fired a select:all event even if all models had already been selected beforehand. Similarly, deselectAll fired a select:none event even if no model had been selected in the first place. No-ops like this don't trigger an event any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With custom options, it is possible to send additional information to event handlers.
It works by passing an arbitrary, custom option (or a whole bunch of them) to any method. The option doesn't affect the operation of Backbone.Picky, but it is passed on to the event handlers as the last argument.
Options get passed around to all event handlers which are running. In the example above, the event handler is set up for the collection. But it will also pick up an option passed to the
selectmethod of the model, for instance.The feature is based on my previous commits. Tests and documentation are included.