Open
Conversation
mogman1
force-pushed
the
handle_redis_failure
branch
4 times, most recently
from
8801dfd to
8ad3b32
Compare
skunkworker
reviewed
Apr 25, 2023
mogman1
force-pushed
the
handle_redis_failure
branch
from
8ad3b32 to
f239104
Compare
mogman1
force-pushed
the
handle_redis_failure
branch
4 times, most recently
from
78ab837 to
f33f858
Compare
mogman1
force-pushed
the
handle_redis_failure
branch
from
f33f858 to
ff8f75d
Compare
mogman1
commented
Apr 28, 2023
| end | ||
|
|
||
| def write(key, value) | ||
| def write(key, value, _options = nil) |
Author
There was a problem hiding this comment.
Updated these to match signatures of Activesupport::Cache::Store
| describe ::ActiveRemote::Cached::ArgumentKeys do | ||
| it "does not mutate a string by default" do | ||
| ::ActiveRemote::Cached::ArgumentKeys.new("hello", {}).cache_key.must_equal("hello") | ||
| _(::ActiveRemote::Cached::ArgumentKeys.new("hello", {}).cache_key).must_equal("hello") |
Author
There was a problem hiding this comment.
These types of changes were made due to deprecation warnings from Minitest about calling methods like must_equal directly on objects.
skunkworker
reviewed
Apr 28, 2023
skunkworker
reviewed
Apr 28, 2023
Author
|
As a note, I'd definitely prefer to publish a release candidate version of this first to do extra validation. Things worked as I expected testing locally, but abundance of caution and all that. |
film42
reviewed
May 1, 2023
film42
reviewed
May 1, 2023
|
LGTM |
added 2 commits
May 6, 2023 13:36
mogman1
force-pushed
the
handle_redis_failure
branch
from
28d02f1 to
ca09ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes warnings and specs, adds handling for upstream cache failure by falling back to RPC call. Also sets up github workflow to automatically run pipelines for multiple ruby / activesupport versions.