-
-
Notifications
You must be signed in to change notification settings - Fork 266
Disable local authentication and enable OIDC auto-redirect #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This configuration adds a local OIDC provider with the following credentials: admin@wakapi.test:password
|
Hello @muety, Here are the logs from my CI execution: |
|
CI is fixed 👍 |
muety
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may add a check to the PostSignup() view as well, probably right next to where AllowSignup is already being checked anyway.
Apart from that, your code looks good! 👍
Please add a view basic tests and let me know once this is ready for final review.
41978b4 to
1f71419
Compare
|
Hi @muety, I believe I have finished the implementation. Please take another look at the changes; I have also implemented your suggested code changes. I've added unit tests for the following scenarios:
Could you please verify if the unit tests are implemented correctly, especially regarding the configuration changes within the tests? My understanding is that the configuration is reset for each test. If that is not the case, please let me know, and I will revise the tests accordingly. To make testing this PR easier, I have put together a small Docker Compose setup with a simple OIDC provider, along with the corresponding Wakapi configuration: Wakapi configuration: security:
disable_local_auth: true
# [...]
oidc: # list of openid connect providers available for user signup and login, see https://github.com/muety/wakapi/wiki/OpenID-Connect-login-(SSO)
- name: oidc
display_name: OIDC
client_id: wakapi
client_secret: wakapi
endpoint: http://localhost:5556/dex/ |
|
Amazing contribution, thanks a lot! 🙌 |

Implementation of #897
Closes #897