Skip to content

add unit tests#5

Merged
mr-easy merged 1 commit intomr-easy:mainfrom
flepied:tests
Apr 27, 2025
Merged

add unit tests#5
mr-easy merged 1 commit intomr-easy:mainfrom
flepied:tests

Conversation

@flepied
Copy link
Contributor

@flepied flepied commented Apr 21, 2025

  • add some unit tests in tests/test_streaming_indicators.py
  • add a GitHub workflow to run the unit tests
  • fix a bug in SMMA detected by the unit tests

@mr-easy
Copy link
Owner

mr-easy commented Apr 23, 2025

thanks for this, this was one of the long pending task. will merge this after checking.
Can you create some more test cases using talib? I consider talib to be de-facto library for technical indicators, and our calculations should match talib's. I usually do this on my local whenever I create a new indicator.
We can keep some sample data, and for each indicator existing (and whenever newly added), create a mapping with talib function.

@flepied
Copy link
Contributor Author

flepied commented Apr 24, 2025

I would prefer to add TA-lib verification in another PR, as this will require extra steps to install TA-lib. Could you approve the workflow to see if the GitHub action is working? I cannot test it locally...

@flepied flepied force-pushed the tests branch 3 times, most recently from 60e0cd5 to 7a7e5a1 Compare April 26, 2025 16:45
- add some unit tests in tests/test_streaming_indicators.py
- add a GitHub workflow to run the unit tests
- fix a bug in SMMA detected by the unit tests
@mr-easy mr-easy merged commit cf3bc63 into mr-easy:main Apr 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants