Add new Functional Widget requirement (example)#4
Open
mpyne-navy wants to merge 1 commit intomasterfrom
Open
Conversation
Intended as a usecase to demonstrate review functionality as part of governance/administration
mpyne-navy
commented
Jul 5, 2017
Owner
Author
mpyne-navy
left a comment
mpyne-navy
left a comment
There was a problem hiding this comment.
See the inline comments. Overall needs clarification on scope.
| 1. ADE should definitely do the thing. | ||
| 2. ADE should do the one thing, but not the other thing. | ||
| 3. ADE must comply with applicable laws/regulations/policys (LRPs) for all the things. | ||
| 4. ADE SHALL provide an Enterprise Functional Widget Factory (EFWF). |
Owner
Author
There was a problem hiding this comment.
Is this compliant with the style guide? We don't use all-caps "ADE $verb" anywhere else. Should be "ADE should..."
Also, is ADE the right spot for an "Enterprise Functional Widget Factory"? What is the reason to put it in ADE instead of in the Enterprise Services project where it belongs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended as a usecase to demonstrate review functionality as part of governance/administration