Allow request IP candidates to contain ports#174
Merged
mpolden merged 2 commits intompolden:masterfrom Feb 11, 2026
Merged
Conversation
mpolden
reviewed
Feb 7, 2026
Owner
|
Format with |
Contributor
Author
|
I believe that is what I did initially, which caused all the comments on the old tests to get lined up with the new, longer lines. |
Contributor
Author
|
Separating the tests with an empty line seems to make |
|
I think there is a bug in this change. while my IP |
|
Reverted to 861f17b which fixed the problem. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the flow of
ipFromRequestto run allremoteIPcandidates throughnet.SplitPortHost(if applicable) regardless of source, instead of treatinghttp.Request.RemoteAddras the lone special case.The motivation behind this is that Azure Application Gateways add the
X-Forwarded-Forheader as a comma separated list ofIP:portinstead of each entry just containing the IP address (ref), making it unnecessarily difficult to deploy echoip as-is to Azure Web App.