Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades multiple dependencies across the project, focusing on React 18 → 19, Vite 5 → 7, Storybook 8 → 9, Node.js 20 → 24, and TypeScript 5.1 → 5.9. Key changes include TypeScript strict typing improvements and Docker build process restructuring.
- Upgraded React and related packages from v18 to v19
- Updated build tools including Vite (5→7) and Storybook (8→9)
- Enhanced Docker multi-stage builds with named stages and volume management
Reviewed Changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/vite.config.ts | Simplified config structure and updated build targets |
| packages/ui/src/modules/location/components/location.tsx | Fixed TypeScript strict typing for useRef |
| packages/ui/src/modules/favorites/components/favorites.tsx | Fixed TypeScript strict typing for useRef |
| packages/ui/src/hooks/useInitMap.ts | Fixed TypeScript strict typing for useRef |
| packages/ui/src/hooks/useDocMeta.ts | Fixed TypeScript strict typing for useRef and querySelector |
| packages/ui/src/components/selectors/directions.tsx | Added parentheses for clarity in ternary expression |
| packages/ui/package.json | Updated React, TypeScript types, Vite and related dependencies |
| packages/components/package.json | Updated React peer dependencies and Storybook packages |
| packages/components/.storybook/main.ts | Modernized Storybook configuration structure |
| package.json | Added platform management scripts and updated dev dependencies |
| docs/development.md | Added troubleshooting guide for Rollup binary issues |
| compose.override.yaml | Enhanced Docker development setup with named volumes |
| Dockerfile | Restructured with multi-stage builds for better optimization |
| .github/workflows/e2e.yml | Updated Node.js version to 24.9.0 |
| .github/workflows/ci.yml | Updated Node.js version to 24.9.0 |
| .env.example | Updated with proper development environment defaults |
| .dockerignore | Enhanced to ignore build outputs and nested node_modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| export default defineConfig({ | ||
| envDir: resolve('../..'), | ||
| cacheDir: '/tmp/vite-cache-ui', |
There was a problem hiding this comment.
[nitpick] The hardcoded cache directory /tmp/vite-cache-ui may cause issues in Docker environments or systems where /tmp is mounted differently. Consider using a relative path or environment variable to make this more flexible across different deployment scenarios.
| cacheDir: '/tmp/vite-cache-ui', | |
| cacheDir: env.VITE_CACHE_DIR ? env.VITE_CACHE_DIR : resolve(__dirname, '.vite-cache-ui'), |
| '/favorite': env.API_HOST, | ||
| '/restbus': env.API_HOST | ||
| } | ||
| export default defineConfig({ |
There was a problem hiding this comment.
The proxy variable is defined but no longer used after removing the function wrapper. This will cause the proxy configuration to be undefined, breaking the development server's API proxying functionality.
1 participant
No description provided.