Close audio groups immediately. #870
Merged
+118
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic would only close an audio group when the next audio frame was created. This is kind of silly, as we know the next audio frame is always going to be a keyframe. This is the cause of the "skipping slow group" console spam even though no data is being dropped.
As an optimization, we also now create a large audio group when an fMP4 fragment contains multiple audio frames. There's not much point bursting a ton of tiny audio group especially with the current "one active group" logic, although that is being fixed.