Fix type warnings: string indexing returns UInt16 instead of Int#17
Open
peter-jerry-ye wants to merge 2 commits intomasterfrom
Open
Fix type warnings: string indexing returns UInt16 instead of Int#17peter-jerry-ye wants to merge 2 commits intomasterfrom
peter-jerry-ye wants to merge 2 commits intomasterfrom
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
The guard statement was missing the else clause, which is required in MoonBit. Added panic() as the error handler to match the behavior of op_set which also panics on invalid index. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed type warnings throughout the codebase by updating string indexing operations to use UInt16 instead of Int. This addresses the breaking change where
string[i]now returns UInt16 rather than Int.Changes
Implementation Details
The main change involves converting string indexing results from UInt16 to Int where needed, or updating variable types to match the new UInt16 return type. This ensures compatibility with the updated string indexing behavior while keeping the codebase functional.
Goal
These changes aim to eliminate all warnings with minimal modifications, ensuring
moon checkworks properly and ideallymoon testas well. The package functionality is preserved while addressing the type system changes.