Bump moonrun to v8 145 and migrate scope APIs#1471
Draft
peter-jerry-ye wants to merge 3 commits intomainfrom
Draft
Bump moonrun to v8 145 and migrate scope APIs#1471peter-jerry-ye wants to merge 3 commits intomainfrom
peter-jerry-ye wants to merge 3 commits intomainfrom
Conversation
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the rusty_v8 dependency from 0.106.0 to 145.0.0
Pro: this allows user building on Windows aarch64 easier because starting from 145.0.0, Windows aarch64 is supported.
Con: this makes the binary size significantly larger in some cases (+15%)
So we might this PR later when there's a stronger reason. For the Wasm toolchain, we will switch not to use
moonrunfor the runner since Node.js is required anyway.Metadata