Open
Conversation
Collaborator
Pull Request Test Coverage Report for Build 2638Details
💛 - Coveralls |
aeabf96 to
ace9749
Compare
ace9749 to
81ae74c
Compare
31b8a12 to
8db3295
Compare
8db3295 to
029a2b5
Compare
4915652 to
8c34579
Compare
8c34579 to
0b7b786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a full surface regex API for both
stringandbytes, built on top of the existing regex engine and parser infrastructure.What changed
Regex::new(StringView) -> Regex raiseBytesRegex::new(StringView) -> BytesRegex raiseRegex::escape(StringView) -> StringViewBytesRegex::escape(StringView) -> StringViewRegexandBytesRegex:findreplace_bysplitinternal/regex_parsertointernal/regex_syntax.internal/regex_syntax::escapewith dedicated tests.string/bytesREADME regex sections with syntax coverage, constraints, and runnable examples.Semantics and notes
Tests
find