Improve json conversion and stringify behavior#3210
Open
Conversation
Collaborator
Pull Request Test Coverage Report for Build 2569Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Int/UInt.stringify/escapebehavior to avoid unwanted indentation/newlines and improve common-case performance for unescaped strings.JsonPathhelper APIs to improve discoverability.Description
Json::as_*,Json::item,Json::value) out of the main module intojson/deprecated.mbtand left deprecation hints in place.from_jsonimplementations forIntandUIntto reject fractional numbers by checkingn == n.trunc()and added corresponding tests injson/from_json_test.mbtthat assert fractional values fail with anexpected integererror.Json::stringifyto not emit a leading indent for objects until the first property is written and to avoid emitting a trailing indent for empty objects when a replacer filtered out members, fixing compact output whenReplacer::keep([])is used.escapethat returns the original string when no characters require escaping to avoid extra allocation/work in the common case.JsonPathand itsadd_index/add_keyhelpers and added a unit test verifying replacer + indentation behavior injson/json_test.mbt.Testing
moon infoto update package metadata and ensure interfaces are consistent, which completed successfully.moon fmtto format changes, which completed successfully.moon test, and all tests passed:Total tests: 5632, passed: 5632, failed: 0.Codex Task