Skip to content

refactor: deprecated unused bencherror#3124

Open
Yu-zh wants to merge 1 commit intomainfrom
Yu-zh/deprecate-bencherror
Open

refactor: deprecated unused bencherror#3124
Yu-zh wants to merge 1 commit intomainfrom
Yu-zh/deprecate-bencherror

Conversation

@Yu-zh
Copy link
Collaborator

@Yu-zh Yu-zh commented Jan 7, 2026

This type is not used actually


Open with Devin

@coveralls
Copy link
Collaborator

coveralls commented Jan 7, 2026

Pull Request Test Coverage Report for Build 2635

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.98%

Totals Coverage Status
Change from base Build 2631: 0.0%
Covered Lines: 11914
Relevant Lines: 12413

💛 - Coveralls

@Yu-zh Yu-zh marked this pull request as draft January 7, 2026 03:25
@bobzhang
Copy link
Contributor

bobzhang commented Feb 5, 2026

@Yu-zh is this relevant?

@Yu-zh Yu-zh force-pushed the Yu-zh/deprecate-bencherror branch from 43d8bb1 to 6340a0f Compare February 14, 2026 08:15
@Yu-zh Yu-zh marked this pull request as ready for review February 14, 2026 08:15
@Yu-zh
Copy link
Collaborator Author

Yu-zh commented Feb 14, 2026

@bobzhang

Yes, sorry I forgot to follow up. I have checked that BenchError is no longer used by the test driver.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants