feat(mojaloop/#3488): enable batch processing#415
Draft
Conversation
vijayg10
requested review from
elnyry-sam-k,
lewisdaly,
mdebarros,
millerabel and
simeonoriko
as code owners
24 tasks
millerabel
reviewed
Sep 1, 2023
.../technical/central-ledger/assets/diagrams/sequence/seq-position-1.3.1-prepare-batch.plantuml
Outdated
Show resolved
Hide resolved
.../technical/central-ledger/assets/diagrams/sequence/seq-position-1.3.1-prepare-batch.plantuml
Outdated
Show resolved
Hide resolved
| end note | ||
| DB --> FACADE_POSITION_FULFIL: Return current state of transfer from DB | ||
| deactivate DB | ||
| FACADE_POSITION_FULFIL <-> FACADE_POSITION_FULFIL: Validate current state (transferState is 'RECEIVED-FULFIL')\n<color #FF0000><b>Error code:</b> 2001</color> against failing transfers\nBatch is not rejected as a whole |
Member
There was a problem hiding this comment.
Where is Payment Condition validated using the pre-image from the fulfill? Must not move a transfer to COMMITTED unless payment condition is fulfilled.
Member
There was a problem hiding this comment.
Hi @millerabel, great question.
It is done by the Central-Ledger Fulfil Handler, which will result in an event which will be consumed by the Central-Ledger Position Handler (i.e. by either the existing Position processor, or the changes proposed here for batch processing) to either finalise the COMMIT(i.e. commit funds to Payee) or ABORT (i.e. release funds to Payer).
mdebarros
reviewed
Sep 11, 2023
Member
There was a problem hiding this comment.
Some suggested changes to address @millerabel's comment --> #415 (comment)
...chnical/central-ledger/assets/diagrams/sequence/seq-position-1.3.4.5-prepare-domain.plantuml
Outdated
Show resolved
Hide resolved
...chnical/central-ledger/assets/diagrams/sequence/seq-position-1.3.4.5-prepare-domain.plantuml
Outdated
Show resolved
Hide resolved
…ition-1.3.4.5-prepare-domain.plantuml Co-authored-by: Miguel de Barros <miguel@debarros.me>
…ition-1.3.4.5-prepare-domain.plantuml Co-authored-by: Miguel de Barros <miguel@debarros.me>
…m/mojaloop/documentation into feat/3488-enable-batch-processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.