read max model len from hf config#94
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @x574chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the flexibility and accuracy of determining the maximum sequence length for models within the system. It shifts from primarily relying on a fixed default or environment variables to dynamically reading the model's inherent maximum position embeddings from its configuration, ensuring that the system's operational limits align more closely with the model's capabilities. This change also provides a significantly increased default maximum length for general use.
Highlights
- Configuration Update: Increased the default value for the
--max_lengthargument in the API server configuration from 32,000 to 128,000. - Dynamic Model Length Determination: Implemented logic to dynamically determine the
engine_max_lengthfor the Allspark model configuration. This now considers themax_position_embeddingsattribute from the model's configuration (if available) and takes the minimum of that value and the configured--max_length. - Runtime Token Limit Alignment: Updated the Qwen-VL runtime to derive its
max_total_lendirectly from theas_config.engine_max_lengthandmax_input_lenfrommax_total_len - 1, removing reliance onDS_LLM_MAX_IN_TOKENSandDS_LLM_MAX_TOKENSenvironment variables.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Warning Gemini is unable to generate a review due to a potential policy violation. |
|
Fix #93 |
No description provided.