Adding script for computing boosted com-charge from analytical expressions#113
Open
akhairna wants to merge 3 commits intomoble:mainfrom
Open
Adding script for computing boosted com-charge from analytical expressions#113akhairna wants to merge 3 commits intomoble:mainfrom
akhairna wants to merge 3 commits intomoble:mainfrom
Conversation
scri/pn/boosted_comcharge.py
Outdated
Comment on lines
11
to
12
| md: Metadata | ||
| Metadata object from which the callables can be computed. |
Contributor
There was a problem hiding this comment.
From the POV of this function, all it needs are the two masses (or the total mass and symmetric mass ratio). Why is it preferable to ask for md instead of m1/m2 or m/nu?
Contributor
Author
There was a problem hiding this comment.
Thats true! It needs only the total mass and nu. Since I was using the metadata, I had designed it like that. I can make those edits. I am wondering if it needs the total mass m, since we scale it to 1. I had included it for the accurate comparison with PN, but that prefactor can be replaced by 1.
akhairna
force-pushed
the
com_charge_fit
branch
from
5336e8b to
3420bbd
Compare
Contributor
Author
|
@moble do you have any comments or feedback for this PR? |
moble
requested changes
Feb 4, 2026
Co-authored-by: Mike Boyle <moble@users.noreply.github.com>
akhairna
force-pushed
the
com_charge_fit
branch
from
5e36c13 to
2a2bb91
Compare
Contributor
Author
|
Hi @moble and @duetosymmetry. I have incorporated the changes. Please let me know if you have any further comments or feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @duetosymmetry, @moble, and @keefemitman, I am adding the script containing the PN expressions for the boosted com charge. This is the script that I hadn't included in the previous PR. Its function is to provide arguments to the
map_to_superrest_framefunction to fix the PNBMS frame. I would appreciate any comments and feedback on it.