Open
Conversation
mmp
reviewed
Jan 20, 2026
Owner
mmp
left a comment
mmp
left a comment
There was a problem hiding this comment.
Looks good overall. A few picky things.
mmp
reviewed
Feb 22, 2026
| "icao": "AFR" | ||
| } | ||
| ], | ||
| "callsigns": [ |
| <tr> | ||
| <td>"callsign"</td> | ||
| <td>String</td> | ||
| <td>A specific callsign (eg. AAL123) to use for an aircraft flying this route. (Both callsigns and ICAO cannot be specified at the same time.)</td> |
Owner
There was a problem hiding this comment.
Isn't it that if a callsign is specified, then the icao is ignored? If so, should probably validate in PostDeserialize() just so users aren't confused if they give both.
|
|
||
| var ac *Aircraft | ||
| var acType string | ||
| for range 50 { |
Owner
There was a problem hiding this comment.
I believe that if we only have a callsign and already have an aircraft in the air with that callsign, this will end up running 50 times trying to spawn that callsign repeatedly. In that case it would be good to fail fast and move on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To define specific callsigns in a scenario.
callsignscan be toairlinesin lieu oficao.