Adds a decorator for teeplot called teewrap
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmore500
reviewed
Feb 15, 2025
mmore500
requested changes
Feb 15, 2025
Owner
mmore500
left a comment
mmore500
left a comment
There was a problem hiding this comment.
A few simplifying suggestions.
Owner
|
Started a build on master to see if this is a general CI problem or specific to this branch 👍 https://github.com/mmore500/teeplot/actions/runs/13340934882 |
mmore500
reviewed
Feb 15, 2025
mmore500
reviewed
Feb 15, 2025
mmore500
reviewed
Feb 15, 2025
teeplot/teeplot.py
Outdated
| saveit() | ||
|
|
||
|
|
||
| def validate_teewrap_kwargs(teeplot_kwargs: dict[str, object]): |
Owner
There was a problem hiding this comment.
I’d prefix with an underscore or maybe move inline now that it’s much simpler
mmore500
approved these changes
Feb 15, 2025
Owner
mmore500
left a comment
mmore500
left a comment
There was a problem hiding this comment.
Approve! Just a few minor comments to take care of before merging.
Owner
|
Ah, also looks like there’s |
Co-authored-by: Matthew Andres Moreno <mmore500.login+gpg@gmail.com>
Co-authored-by: Matthew Andres Moreno <mmore500.login+gpg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.