Conversation
Python 3 distinguishes between Unicode `str`ings and byte strings. The socket is expecting bytes, and we've dealing with `str`ings internally so we need to convert in each direction. This fixes the following problems: ``` Unhandled python exception in read callback: TypeError: a bytes-like object is required, not 'str' Unhandled python exception in read callback: TypeError: must be str, not bytes ```
graingert
reviewed
Nov 30, 2021
| buf = s.recv(RECV_SIZE) | ||
| while buf: | ||
| result += buf | ||
| result += buf.decode() |
There was a problem hiding this comment.
you need to use an incremental decoder, or decode the whole value at once in return result.decode()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR:
try…exceptsyntaxboth of which make the plugin work under Python 3.
This addresses the following logged exceptions:
Disclaimer: my Python skills are very limited, but this fixed it for me.