Fix two warnings that clang treats as errors#119
Merged
mkst merged 1 commit intomkst:masterfrom Jan 4, 2026
Merged
Conversation
Owner
|
can you try rebasing off master? I think the CI has broken at some point so I've pushed an attempted fix. |
queueRAM
force-pushed
the
fix_clang_errors
branch
from
af7f2e8 to
9645070
Compare
Contributor
Author
|
Thanks, I rebased on your master branch and pushed, but still looks like part of the CI may still be failing |
Owner
|
Aha - CI got a little further - can you try again (still my fault not yours!) |
(1) src.us/sssv/collision.c:295:29: error: incompatible function pointer types assigning - changed return type from s32 -> u8 to match functions (2) src.us/sssv/camera.c:4302:5: error: implicit declaration of function 'func_8032D680_73ED30' - added func_8032D680_73ED30 prototype to functions.us.h
queueRAM
force-pushed
the
fix_clang_errors
branch
from
9645070 to
0800469
Compare
Owner
|
Looks good, thanks - if you rebase the other two PRs then they should pass the CI too 👍 |
mkst
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) src.us/sssv/collision.c:295:29: error: incompatible function pointer types assigning
(2) src.us/sssv/camera.c:4302:5: error: implicit declaration of function 'func_8032D680_73ED30'