Add 'Root folder' and 'Admins' translations and modify some zh-CN translations#53
Conversation
ghost
commented
Sep 14, 2016
ghost
commented
This reverts commit 9487cba.
Adding spanish translation
mischa78
left a comment
mischa78
left a comment
There was a problem hiding this comment.
Hi, this looks good, thank you! I see some minor problems with the code style like using double quotes instead of single quotes and removing newlines at the end of the file. Can you please check my comments and adjust? Thank you very much.
.gitignore
Outdated
| log/* | ||
| tmp/* | ||
| uploads/* | ||
| .idea |
There was a problem hiding this comment.
This probably does not apply to most people. Can you take it out?
app/mailers/user_mailer.rb
Outdated
| def share_link_email(share_link) | ||
| @share_link = share_link | ||
| mail(:to => share_link.user.email, :reply_to => share_link.user.email, :bcc => share_link.emails, :subject => t(:share_link_email_subject, :email => share_link.user.email)) | ||
| mail(:to => share_link.user.email, :reply_to => share_link.user.email, :bcc => share_link.emails, :subject => t(:share_link_email_subject, :email => share_link.user.email+"("+share_link.user.name+")")) |
There was a problem hiding this comment.
I'd prefer it if you do it like this:
:email => "#{share_link.user.email} (#{share_link.user.name})"
app/models/folder.rb
Outdated
|
|
||
| def self.root | ||
| @root_folder ||= find_by_name_and_parent_id('Root folder', nil) | ||
| @root_folder ||= find_by_name_and_parent_id(Folder.human_attribute_name("folder.root_folder"), nil) |
There was a problem hiding this comment.
I prefer single quotes. Could you please change that in all the human_attribute_name calls?
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
| -- | ||
| Boxroom | ||
| http://boxroomapp.com/ | ||
| <%= root_url %> No newline at end of file |
There was a problem hiding this comment.
Don't remove the last newline please.
|
Now I have some updates according to your requirements and recommended |
4 participants
