fix(AuthDialog): resolve TypeScript error by moving demo component be… #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore meta definition - Move AuthDialogDemo component definition before meta to fix reference error - Remove duplicate AuthDialogDemo function - Remove disabled argTypes for component props (not needed with DemoControls type) - Remove unused AuthDialogProps import
Deploying ui with
|
| Latest commit: |
7523873
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c60c36d.ui-6d0.pages.dev |
| Branch Preview URL: | https://fix-authdialog-story-types.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript reference error in the AuthDialog Storybook configuration by reordering component definitions and simplifying the type structure.
Changes:
- Moved
AuthDialogDemocomponent definition before themetaobject to allow proper referencing - Changed the meta component reference from
AuthDialogtoAuthDialogDemoto align with the demo-focused story controls - Simplified the story props type from
Partial<AuthDialogProps> & DemoControlsto justDemoControls - Removed unused
AuthDialogPropsimport and disabled argTypes that were hiding props no longer exposed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fore meta definition