This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Use HTML Help instead of Windows Help#211
Open
thecatkitty wants to merge 4 commits intomicrosoft:masterfrom
Open
Use HTML Help instead of Windows Help#211thecatkitty wants to merge 4 commits intomicrosoft:masterfrom
thecatkitty wants to merge 4 commits intomicrosoft:masterfrom
Conversation
|
@thecatkitty Thank you for fixing this. I would like to merge this pull request into my own fork, which aims to add transparent UTF-8 support. |
Contributor
|
I highly recommend merging this to the main branch (cc @craigwi). As per Microsoft's own Windows app guidelines, apps using the old help technology should migrate to HTML help as a direct migration path from the now unsupported help system. |
malxau
reviewed
Feb 1, 2022
|
|
||
| Extern TCHAR szWinfileHelp[] EQ( TEXT("WINFILE.HLP") ); | ||
| Extern WCHAR wszWinfileHelp[] EQ( L"WINFILE.HLP" ); | ||
| Extern TCHAR szWinfileHelp[] EQ( TEXT("..\\X86\\WINFILE.HLP") ); |
Contributor
There was a problem hiding this comment.
Why are these path changes needed/related?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes WinFile open CHM file instead of HLP. This resolves #184. In addition, it removes Help on Help command from the menu (there's no such HH functionality).
The code assumes that
winfile.chmis placed inx86directory, which is true for ZIP (not for 1901, apparently...) and Chocolatey releases.