Skip to content

fix undefined property error from getViewLineMinColumn #287189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bryanchen-d wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

fix undefined property error from getViewLineMinColumn #287189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vs/editor/common/viewModel/viewModelImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,10 @@ export class ViewModel extends Disposable implements IViewModel {
* Gives a hint that a lot of requests are about to come in for these line numbers.
*/
public setViewport(startLineNumber: number, endLineNumber: number, centeredLineNumber: number): void {
if (this._lines.getViewLineCount() === 0) {
// No visible lines to set viewport on
return;
}
Comment on lines +771 to +774
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard condition correctly prevents the error, but there's no test coverage for this edge case. Consider adding a test that verifies setViewport behaves correctly when called on a view model with all lines hidden (getViewLineCount() === 0), similar to the existing tests in viewModelImpl.test.ts for hidden areas.

Copilot uses AI. Check for mistakes.
this._viewportStart.update(this, startLineNumber);
}

Expand Down
Loading