Change split strings to byte arrays for drive detection#14
Open
oclyke wants to merge 1 commit intomicrosoft:masterfrom
oclyke:patch-1
Open
Change split strings to byte arrays for drive detection#14oclyke wants to merge 1 commit intomicrosoft:masterfrom oclyke:patch-1
oclyke wants to merge 1 commit intomicrosoft:masterfrom
oclyke:patch-1
Conversation
Using python 3.7.2 on Windows 10 (version 1803, build 17134.472, and running in Bootcamp) I repeatedly got the following error:
```
Converting to uf2, output size: 50176, start address: 0x8000000
Traceback (most recent call last):
File "uf2conv.py", line 292, in <module>
main()
File "uf2conv.py", line 279, in main
drives = get_drives()
File "uf2conv.py", line 176, in get_drives
for line in r.split('\n'):
TypeError: a bytes-like object is required, not 'str'
```
As well as a similar error for the regular expressions split line immediately following. Changing the split strings to byte array objects solved the problem for me, as shown in this commit
|
The patch did not work for me. I am a Python novice, but found this solution that worked for me: Change line 176 "for line in r.split('\n'):" to "for line in r.decode().split('\n'):" The function call "decode()" changes the byte array to a string for further processing. Hope that helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using python 3.7.2 on Windows 10 (version 1803, build 17134.472, and running in Bootcamp) I repeatedly got the following error:
As well as a similar error for the regular expressions split line immediately following. Changing the split strings to byte array objects solved the problem for me, as shown in this commit