Skip to content

Conversation

@DerkKooi
Copy link
Contributor

No description provided.

@DerkKooi DerkKooi requested review from awvwgk and tvogels January 15, 2026 12:33
@awvwgk awvwgk added the documentation Improvements or additions to documentation label Jan 16, 2026
@awvwgk awvwgk requested a review from Copilot January 16, 2026 10:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the GPU installation instructions for Skala, adding support for both CUDA 12 and CUDA 13 environments.

Changes:

  • Added two new conda environment files for GPU support (CUDA 12 and CUDA 13)
  • Updated README.md with comprehensive GPU installation instructions for both conda and pip
  • Updated docs/installation.rst to reference the new environment files and provide CUDA 13 installation instructions

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.

File Description
environment-gpu_cu12.yml New conda environment file for CUDA 12 GPU support with pytorch-gpu, cupy, and cuda toolkit dependencies
environment-gpu_cu13.yml New conda environment file for CUDA 13 GPU support with pytorch-gpu, cupy, and cuda toolkit dependencies
docs/installation.rst Updated installation documentation to reference new environment files and add CUDA 13 gpu4pyscf installation instructions
README.md Added GPU installation section with conda and pip instructions for CUDA 12 and 13 support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the possibility to stay with a single GPU environment? Maybe we can add in the instructions that it is necessary to update the Cuda version in the environment for Cuda 13 rather than providing two identical environments with one different version constraint.

Alternatively, could you check whether CONDA_OVERRIDE_CUDA still works for setting the Cuda version lower bound from the environment?

@DerkKooi DerkKooi force-pushed the microsoft/derkkooi/readme_update branch from 34b6de1 to 2103a5f Compare January 26, 2026 09:02
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DerkKooi DerkKooi merged commit cbc4e77 into main Jan 26, 2026
17 of 18 checks passed
@DerkKooi DerkKooi deleted the microsoft/derkkooi/readme_update branch January 26, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants